Recently I stumbled across Androids auto brightness feature\/bug. On all Android phones I ever possessed, the auto brightness was working as expected. When you enter a brighter area the display gets brighter. Returning back to a darker zone the display gets dimmed. On my own AOSP(Android Open Source Project)-build my phone display never got dimmed. When a certain brightness level was reached the display stayed on this level, even if I covered the light sensor. The brightness remained so until the phone got locked and\/or the phone display went off. I tested this behavior on three Google phones: Nexus One, Nexus S and on the Galaxy Nexus. On other phones I could not reproduce this. All phones I’ve tested were on their original software. The fact detecting this on Google phones (AOSP builds) but not on others tells me that many phone providers (e.g. Samsung) are not happy with it and changed this behavior by themselves.
\n <\/p>\n
I found the responsible source code for this\u00a0in the frameworks\/base\/services\/java\/com\/android\/server\/PowerManagerService.java class.<\/p>\n
private int mHighestLightSensorValue = -1;\n...\nprivate int setScreenStateLocked(boolean on) {\n int err = Power.setScreenState(on);\n if (err == 0) {\n mLastScreenOnTime = (on ? SystemClock.elapsedRealtime() : 0);\n if (mUseSoftwareAutoBrightness) {\n enableLightSensor(on);\n if (!on) {\n \/\/ make sure button and key backlights are off too\n mButtonLight.turnOff();\n mKeyboardLight.turnOff();\n \/\/ clear current value so we will update based on\n \/\/ the new conditions when the sensor is reenabled.\n mLightSensorValue = -1;\n \/\/ reset our highest light sensor value when the\n \/\/\u00a0screen turns off\n mHighestLightSensorValue = -1;\n }\n }\n }\n return err;\n }\n...\nprivate void dockStateChanged(int state) {\n synchronized (mLocks) {\n mIsDocked = (state != Intent.EXTRA_DOCK_STATE_UNDOCKED);\n if (mIsDocked) {\n mHighestLightSensorValue = -1;\n }\n if ((mPowerState & SCREEN_ON_BIT) != 0) {\n \/\/ force lights recalculation\n int value = (int)mLightSensorValue;\n mLightSensorValue = -1;\n lightSensorChangedLocked(value);\n }\n }\n }\n...\n \/\/ do not allow light sensor value to decrease\n if (mHighestLightSensorValue < value) {\n mHighestLightSensorValue = value;\n }\n if (mLightSensorValue != value) {\n mLightSensorValue = value;\n if ((mPowerState & BATTERY_LOW_BIT) == 0) {\n \/\/ use maximum light sensor value seen since screen went on\n \/\/ for LCD to avoid flicker\n \/\/ we only do this if we are undocked, since lighting\n \/\/ should be stable when stationary in a dock.\n int lcdValue = getAutoBrightnessValue(\n (mIsDocked ? value : mHighestLightSensorValue),\n mLcdBacklightValues);\n...<\/pre>\nIn the copied code we see the mLightSensorValue never gets smaller. Its restored to -1 when the class get initialized, the phone gets locked, phone display is off or when ever the phone receives a dockingEvent.<\/p>\n
\/\/ do not allow light sensor value to decrease\n if (mHighestLightSensorValue < value) {\n mHighestLightSensorValue = value;\n }<\/pre>\nAfterwards mHighestLightSensorValue is used to actually set the new brightness:<\/p>\n
int lcdValue = getAutoBrightnessValue(\n (mIsDocked ? value : mHighestLightSensorValue),\n mLcdBacklightValues);<\/pre>\nI fixed this in my build by replacing the last code snip with this one:<\/p>\n
int lcdValue = getAutoBrightnessValue(value, mLcdBacklightValues);<\/pre>\nSo the lcdValue is always corresponding with the light sensor.
\nI found this code, handling the auto brightness, already in Android 2.2 [froyo] and it’s still the same in Android 4.0 [ICS]. I did not analyze older code than 2.2, so I can’t exclude that the behavior was the same… Google defends their code with a comment saying they want to avoid flickering when the display is on.
\n <\/p>\n
Faster reaction to light sensor values<\/strong><\/span><\/h2>\nFurthermore I replaced the reaction time for the sensor.<\/p>\n
private static final int LIGHT_SENSOR_DELAY = 1000; \/\/[ms]<\/pre>\nOriginally the value was set to 2000. Now the auto brightness adjusting reacts a lot faster.
\n <\/p>\n
Change sensor levels and lcd back light values<\/strong><\/span><\/h2>\nFinally I changed the sensor triggers for the auto brightness, intended to have more levels and reach better battery life. As you may notice I took pretty low lcdBacklightValues. This configuration is hardly depending on your phone, I use this values on my Samsung Galaxy SII (GT-I9100). You find the configuration in\u00a0frameworks\/base\/core\/res\/res\/values\/config.xml. If you’re using an overlay directory for device specific configuration, e.g. device\/samsung\/sgs2\/overlay\/…, the configuration might be there.<\/p>\n
<integer-array name=\"config_autoBrightnessLevels\">\n <item>15<\/item>\n <item>150<\/item>\n <item>1500<\/item>\n <item>8500<\/item>\n <item>11000<\/item>\n <item>15000<\/item>\n<\/integer-array>\n<integer-array name=\"config_autoBrightnessLcdBacklightValues\">\n <item>5<\/item>\n <item>35<\/item>\n <item>55<\/item>\n <item>80<\/item>\n <item>120<\/item>\n <item>160<\/item>\n <item>255<\/item>\n<\/integer-array>\n<integer-array name=\"config_autoBrightnessButtonBacklightValues\">\n <item>255<\/item>\n <item>255<\/item>\n <item>0<\/item>\n <item>0<\/item>\n <item>0<\/item>\n <item>0<\/item>\n <item>0<\/item>\n<\/integer-array>\n<integer-array name=\"config_autoBrightnessKeyboardBacklightValues\">\n <item>0<\/item>\n <item>0<\/item>\n <item>0<\/item>\n <item>0<\/item>\n <item>0<\/item>\n <item>0<\/item>\n <item>0<\/item>\n<\/integer-array><\/pre>\nRemember always to have one more item in\u00a0autoBrightnessLcdBacklightValues,\u00a0autoBrightnessButtonBacklightValues and\u00a0autoBrightnessKeyboardBacklightValues than in\u00a0autoBrightnessLevels. Otherwise you will encounter ArrayIndexOutOfBounds exceptions or the function will return wrong values! Because of the code below.<\/p>\n
private int getAutoBrightnessValue(int sensorValue, int[] values) {\n try {\n int i;\n for (i = 0; i < mAutoBrightnessLevels.length; i++) {\n if (sensorValue < mAutoBrightnessLevels[i]) {\n break;\n }\n }\n return values[i];\n } catch (Exception e) {\n \/\/ guard against null pointer or index out of bounds errors\n Slog.e(TAG, \"getAutoBrightnessValue\", e);\n return 255;\n }\n }<\/pre>\n <\/p>\n","protected":false},"excerpt":{"rendered":"
Recently I stumbled across Androids auto brightness feature\/bug. On all Android phones I ever possessed, the auto brightness was working as expected. When you enter a brighter area the display gets brighter. Returning back to a darker zone the display … Continue reading